Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bronze quality scale to Airzone Cloud #141500

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Noltari
Copy link
Contributor

@Noltari Noltari commented Mar 26, 2025

Proposed change

Add bronze quality scale to Airzone Cloud integration.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
@NoRi2909
Copy link
Contributor

Question / suggestion as a translator regarding the air quality control options:

Currently air_quality has the friendly name "Air Quality mode"
And air_quality_active has the friendly name "Air Quality active"

Being capitalized this indicates that we should keep this as a feature name in translations.
But the online docs explain the latter as "Indicates that the air quality control is running."

Could we change both as follows?

air_quality : "Air quality mode"
air_quality_active: "Air quality control active"

Then I could translate "air quality" in both.

Copy link
Contributor

@dontinelli dontinelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my view quality_scale.yaml should contain all rules (and the respective assessment), not only the bronze ones.

@home-assistant home-assistant bot marked this pull request as draft March 27, 2025 12:32
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants