Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow liter for gas sensor device class #141518

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

Arnie97
Copy link

@Arnie97 Arnie97 commented Mar 26, 2025

Proposed change

Haier water heaters report their gas usage in liters,
so the corresponding custom integration produces WARNING logs like:

WARNING (Dummy-1) [homeassistant.components.sensor] Entity sensor.a08222a4c94c_totalusegasl (<class 'custom_components.haier.sensor.HaierSensor'>) is using native unit of measurement 'L' which is not a valid unit for the device class ('gas') it is using; expected one of ['m³', 'ft³', 'CCF']; Please update your configuration if your entity is manually configured, otherwise create a bug report at https://github.com/banto6/haier/issues

This patch fix the warning by allowing liter L as a valid unit for the gas sensor device class.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/core, @Shulyaka, mind taking a look at this pull request as it has been labeled with an integration (number) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of number can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign number Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (sensor) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of sensor can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign sensor Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@Arnie97 Arnie97 marked this pull request as ready for review March 27, 2025 03:07
@Arnie97 Arnie97 requested a review from a team as a code owner March 27, 2025 03:07
@abmantis
Copy link
Contributor

We also need to update the valid gas units on the energy sensor for the energy dashboard in homeassistant/components/energy/sensor.py.

@abmantis abmantis marked this pull request as draft March 27, 2025 18:11
@Arnie97 Arnie97 marked this pull request as ready for review March 31, 2025 05:11
@Arnie97
Copy link
Author

Arnie97 commented Mar 31, 2025

Fixed the energy dashboard, please review again

Comment on lines +275 to +278
if self.hass.config.units is METRIC_SYSTEM:
default_price_unit = UnitOfVolume.CUBIC_METERS
else:
default_price_unit = UnitOfVolume.CENTUM_CUBIC_FEET
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to have a second opinion on this, since it will now do a conversion in cases where it didn't before.

Copy link
Contributor

@emontnemery emontnemery Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that we allow gas to be measured either in a volume or as energy, so I don't think this will work (that's what the comment is trying to say).
It should be possible to do some rewrite, but that should happen in a separate PR, not in a PR adding support for liters.

@abmantis abmantis added the second-opinion-wanted Add this label when a reviewer needs a second opinion from another member. label Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix cla-signed core integration: number integration: sensor Quality Scale: internal second-opinion-wanted Add this label when a reviewer needs a second opinion from another member. small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

有一个单位兼容警告
3 participants