-
-
Notifications
You must be signed in to change notification settings - Fork 33.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default preannounce sound to Assist satellites #141522
Add default preannounce sound to Assist satellites #141522
Conversation
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Hey there @OttoWinter, @jesserockz, @kbx81, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
8d36326
to
5849fb1
Compare
* Add default preannounce sound * Allow None to disable sound * Register static path instead of HTTP view * Fix path --------- Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
Will this be available also in Wyoming satellite? |
Please don't comment on closed PRs unless you've found a bug, and want to comment on a specific line in the PR. Thanks! |
Breaking change
Proposed change
Adds a default pre-announcement sound to the
announce
andstart_conversation
actions of Assist satellites, completing the architecture proposal: home-assistant/architecture#1213When
preannounce_media_id
is not set, the defaultpreannounce.mp3
file is provided via a static path URL in theassist_satellite
integration. Settingpreannounce_media_id
to null will disable the sound entirely.Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: