Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle webcal prefix in remote calendar #141541

Merged

Conversation

Thomas55555
Copy link
Contributor

Breaking change

Proposed change

There was a response from a user, which tried to add a webcal URL in the beta to the calendar.
The prefix webcal:// just tells the browser to download a the file. The actual destination is normally just an http server.
So we assume that the proper prefix must be https://
As an alternative we could also just display an error message, for the user which tells him to find a proper url?

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@frenck frenck added this to the 2025.4.0 milestone Mar 27, 2025
@frenck frenck changed the title Handel webcal prefix in remote calendar Handle webcal prefix in remote calendar Mar 27, 2025
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Thomas55555 👍

../Frenck

@frenck frenck merged commit 43a5c7d into home-assistant:dev Mar 27, 2025
34 checks passed
frenck pushed a commit that referenced this pull request Mar 27, 2025
Handel webcal prefix in remote calendar
@Thomas55555 Thomas55555 deleted the Handel-webcal-prefix-in-remote-calendar branch March 27, 2025 17:45
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants