Revert "Promote after dependencies in bootstrap" #141584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3766040.
|
The direct cause of the problem is that we don't require integrations to list their platforms as dependencies and we also allow the platforms themselves to have after_dependencies. That causes the resolution algorithm to not have full knowledge, which results in a deadlock. The alternative fix for the reported issue would be to merge #141576 (which we want to do anyway). |
balloob
approved these changes
Mar 27, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #140352
There's currently a single integration which both loads early, and which has after dependencies:
cloudThe cloud after dependencies pull in a large dependency tree, causing a deadlock #141516
Once we have reviewed the
cloudafter dependencies and removed unneeded ones, we should again add reverts #140352