-
-
Notifications
You must be signed in to change notification settings - Fork 33.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more Foscam switches #141633
base: dev
Are you sure you want to change the base?
Add more Foscam switches #141633
Conversation
…Foscam-core into some-feature
…Foscam-core into some-feature
Hey there @krmarien, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
||
PLATFORMS = [Platform.CAMERA, Platform.SWITCH] | ||
PLATFORMS = [Platform.CAMERA, Platform.NOTIFY, Platform.NUMBER, Platform.SWITCH] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR is to big. We allow only adding one platform at the time.
Please split this PR into multiple:
- One is adding new switch entites
- One is adding the notify platform
- One is adding the number platform
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Breaking change
Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: