Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "meter" from entity names of rainforest_eagle sensors #141641

Merged
merged 3 commits into from
Mar 28, 2025

Conversation

NoRi2909
Copy link
Contributor

@NoRi2909 NoRi2909 commented Mar 28, 2025

Proposed change

(This PR applies the same fixes as #141487 for the rainforest_ravenintegration)

In rainforest_eagle the three sensors

  • power_demand
  • total_energy_delivered
  • total_energy_received

currently add "meter" in their friendly names.

This does not provide any useful information and is rather irritating instead – it sounds like these are the power demands or consumption of the meter itself. But they are the measured values.

This commit removes "meter" from the names making them simpler and more precise, too.

For consistency the naming of meter_price is changed to energy_price.

In addition the sentence-casing of "Installation code" is fixed.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @gtdiehl, @jcalbert, @hastarin, mind taking a look at this pull request as it has been labeled with an integration (rainforest_eagle) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of rainforest_eagle can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign rainforest_eagle Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@NoRi2909 NoRi2909 changed the title Fix misleading friendly names of rainforest_eaglr sensors Fix misleading friendly names of rainforest_eagle sensors Mar 28, 2025
@NoRi2909 NoRi2909 marked this pull request as ready for review March 28, 2025 10:35
@NoRi2909 NoRi2909 changed the title Fix misleading friendly names of rainforest_eagle sensors Remove "meter" from entity names of rainforest_eagle sensors Mar 28, 2025
@thecode thecode merged commit 577f86b into home-assistant:dev Mar 28, 2025
34 checks passed
@NoRi2909 NoRi2909 deleted the patch-84 branch March 28, 2025 10:52
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants