Always set pause feature on Music Assistant mediaplayers #141686
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
In a previous release we have strictly tied the HA media player features to actual player capabilities reported by Music Assistant players (which are rather dynamic given the broad player support of MA).
This works well except for one thing, which is pause support because the MA user interface does not distinguish between a player that does (not) support pause, it will silently use stop under the hood with a resume point. So this causes some confusion for users because in the HA interface they can suddenly not use pause anymore for players that do not support it.
After a bit back and forth discussion we decided that its best if the HA pattern follows the MA behavior so it feels more natural to a user.
Background story can be read in the linked issue report.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: