-
-
Notifications
You must be signed in to change notification settings - Fork 33.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure EcoNet operation modes are unique #141689
Conversation
Hey there @w1ll1am23, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
@frenck I was wondering: Shouldn't all things like modes and supported features be sets rather than lists? |
Good question. It would be rather breaking to adjust that, but it has repercussions for the JSON transport with things like the front end. I'm not against it, but... kinda out of scope for this one. |
I know, I was thinking of bringing it up in the architecture discussions. I figured since I had your attention and you were fixing this anyway, I'd feel you out on your thoughts on the issue :) |
Thanks for the merge @jpbede 😀 |
Proposed change
This PR ensures that EcoNet's operation modes are unique.
Reported in #90243
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: