Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure EcoNet operation modes are unique #141689

Merged
merged 1 commit into from
Mar 30, 2025
Merged

Ensure EcoNet operation modes are unique #141689

merged 1 commit into from
Mar 30, 2025

Conversation

frenck
Copy link
Member

@frenck frenck commented Mar 28, 2025

Proposed change

This PR ensures that EcoNet's operation modes are unique.

Reported in #90243

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes Vacation Mode missing from EcoNet #90243
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@frenck frenck added this to the 2025.4.0 milestone Mar 28, 2025
@home-assistant
Copy link

Hey there @w1ll1am23, mind taking a look at this pull request as it has been labeled with an integration (econet) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of econet can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign econet Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@rlippmann
Copy link
Contributor

@frenck I was wondering:

Shouldn't all things like modes and supported features be sets rather than lists?

@frenck
Copy link
Member Author

frenck commented Mar 28, 2025

@frenck I was wondering:

Shouldn't all things like modes and supported features be sets rather than lists?

Good question. It would be rather breaking to adjust that, but it has repercussions for the JSON transport with things like the front end.

I'm not against it, but... kinda out of scope for this one.

@rlippmann
Copy link
Contributor

@frenck I was wondering:
Shouldn't all things like modes and supported features be sets rather than lists?

Good question. It would be rather breaking to adjust that, but it has repercussions for the JSON transport with things like the front end.

I'm not against it, but... kinda out of scope for this one.

I know, I was thinking of bringing it up in the architecture discussions. I figured since I had your attention and you were fixing this anyway, I'd feel you out on your thoughts on the issue :)

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Mar 30, 2025
@jpbede jpbede merged commit 506d485 into dev Mar 30, 2025
33 of 34 checks passed
@jpbede jpbede deleted the frenck-2025-0145 branch March 30, 2025 18:31
@frenck
Copy link
Member Author

frenck commented Mar 30, 2025

Thanks for the merge @jpbede 😀

@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix cherry-picked cla-signed integration: econet Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vacation Mode missing from EcoNet
3 participants