Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve MQTT translation strings #141691

Merged
merged 2 commits into from
Mar 29, 2025
Merged

Improve MQTT translation strings #141691

merged 2 commits into from
Mar 29, 2025

Conversation

jbouwh
Copy link
Contributor

@jbouwh jbouwh commented Mar 28, 2025

Proposed change

Improve MQTT options translation string.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @emontnemery, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (mqtt) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of mqtt can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign mqtt Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@jbouwh jbouwh mentioned this pull request Mar 28, 2025
Open
24 tasks
NoRi2909
NoRi2909 reviewed Mar 28, 2025
View reviewed changes
homeassistant/components/mqtt/strings.json Outdated
@@ -222,7 +222,7 @@
"device_class": "The device class of the {platform} entity. [Learn more.]({url}#device_class)",
"state_class": "The [state_class](https://developers.home-assistant.io/docs/core/entity/sensor/#available-state-classes) of the sensor. [Learn more.]({url}#state_class)",
"unit_of_measurement": "Defines the unit of measurement of the sensor, if any.",
"options": "Options for allowed sensor state values. The sensor’s device_class must be set to Enumeration. The options option cannot be used together with State Class or Unit of measurement."
"options": "Options for allowed sensor state values. The sensor’s device_class must be set to Enumeration. The 'Options' setting cannot be used together with State Class or Unit of measurement."
Copy link
Contributor

@NoRi2909 NoRi2909 Mar 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we should also fix "State Class" and use "State class" instead.
Consistent with "Unit of measurement" which also just capitalizes the first word.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, and "device_class" should be "Device class" then, too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I noticed that already when I was working on the Dutch translations.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated them all

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for me when the new strings rolled in for the German translation.
It always helps to re-read everything in a second language.

Thanks!

@jbouwh jbouwh changed the title Improve MQTT options translation string Improve MQTT translation strings Mar 28, 2025
@jbouwh jbouwh added this to the 2025.4.0 milestone Mar 28, 2025
davet2001
davet2001 approved these changes Mar 29, 2025
View reviewed changes
Copy link
Contributor

@davet2001 davet2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@jbouwh
Copy link
Contributor Author

jbouwh commented Mar 29, 2025

Thanks!

@jbouwh jbouwh merged commit 6ee97f3 into dev Mar 29, 2025
48 checks passed
@jbouwh jbouwh deleted the mqtt-options-transl-string branch March 29, 2025 16:29
frenck pushed a commit that referenced this pull request Mar 29, 2025
@jbouwh @frenck
Improve MQTT translation strings (#141691)
6ad5e9e 
* Improve MQTT options translation string

* more improvements
@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NoRi2909 NoRi2909 NoRi2909 left review comments

@davet2001 davet2001 davet2001 approved these changes

@emontnemery emontnemery Awaiting requested review from emontnemery emontnemery is a code owner

@bdraco bdraco Awaiting requested review from bdraco bdraco is a code owner

Assignees

@bdraco bdraco

@emontnemery emontnemery

Labels
bugfix by-code-owner cherry-picked cla-signed core integration: mqtt Quality Scale: platinum small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2025.4.0
Development

Successfully merging this pull request may close these issues.
6 participants
@jbouwh @davet2001 @NoRi2909 @frenck @bdraco @emontnemery