Styles code improvements, Header component, + Logo component #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I've added some changes to how we use styles.
Also I've worked on the Header component and added a new Logo component.
CSS global variables, Shoelace Classes prefix and design tokens
All color variables were moved to a single
hot.css
file, so we don't create and repeat more global CSS variables. An ideal solution I think would be to have variables named with the prefix--hot-
instead of--sl-l
, but this is something that Shoelace doesn't support.This is different for classes, where I added the
hot-
prefix for the UnoCSS config, now all classes are prefixed, likehot-font-sans
.I've changed all inline styling and hardcoded values (ex: font-size: 2rem) to classes. This was not possible for Shoelace icons, but in that case I used the CSS variable for font-size.
Header component
I've cleaned the code and also moved all styles and its variants to a new
styles.ts
file. I'm still exploring the possibility of having all styles in CSS files and use the @apply directive, but this is not possible yet.Logo component
A new Logo component was added, using SVG files instead of bitmaps.