Skip to content

HPCC-34158 Suppress storing super lfnHash attribute #19891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2025
Merged

HPCC-34158 Suppress storing super lfnHash attribute #19891

merged 1 commit into from
May 26, 2025

Conversation

jakesmith
Copy link
Member

@jakesmith jakesmith commented May 20, 2025 •
edited
Loading

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@jakesmith jakesmith requested a review from ghalliday May 20, 2025 16:30
@github-actions GitHub Actions
Copy link

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-34158

Jirabot Action Result:
Assigning user: jake.smith@lexisnexisrisk.com
Workflow Transition To: Merge Pending
Updated PR

ghalliday
ghalliday reviewed May 21, 2025
View reviewed changes
Copy link
Member

@ghalliday ghalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakesmith one question

dali/ft/filecopy.cpp
@@ -3668,6 +3668,7 @@ cost_type FileSprayer::updateTargetProperties()
((stricmp(aname,"@rowCompressed")==0)&&copyCompressed)||
(stricmp(aname,"@local")==0)||
(stricmp(aname,"@recordCount")==0)
(stricmp(aname,"@lfnHash")==0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this prevent lfnhash being set on the target logical file when copying? Maybe if superTgt is set.

But I am also a bit confused what copying with a target of a superfile actually means. Do you know?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this prevent lfnhash being set on the target logical file when copying? Maybe if superTgt is set.

No, the lfnHash will be calculated and set when the IDistributedFile is attach()'d (which is the point that the logical name is a tied to the instance).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I am also a bit confused what copying with a target of a superfile actually means. Do you know?

I am not really sure, but it has specifically handled via runSuperCopy

@jakesmith
HPCC-34158 Suppress storing super lfnHash attribute
21d907f 
Signed-off-by: Jake Smith <jake.smith@lexisnexisrisk.com>
@jakesmith jakesmith force-pushed the HPCC-34158-suppress-super-lfnhash branch from 6d8de09 to 21d907f Compare May 21, 2025 13:32
@jakesmith jakesmith requested a review from ghalliday May 21, 2025 14:35
ghalliday
ghalliday approved these changes May 26, 2025
View reviewed changes
Copy link
Member

@ghalliday ghalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems plausible...

@ghalliday ghalliday merged commit 279e9a4 into hpcc-systems:candidate-9.6.x May 26, 2025
50 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghalliday ghalliday ghalliday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakesmith @ghalliday