Try anr2me's sceNetInet implementation #19822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After user testing of this, I've decided to go with this to start with (as it seems to work as well as the old fork), but port over many aspects of @JustAWhiteBloodCell 's version on top, such as socket remapping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't decide whether to start with this and bring over ideas from @JustAWhiteBloodCell 's implementation, or vice versa. As mentioned in anr2me#21 , this is missing features and important fixes, but on the other hand, people are actively using this code to play.
Also, I think this code style is easier to read, although, that may change when we add socket remapping etc...
Anyway, CI will make a build of this for people to test.