Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infrastructure Auto DNS: Preconfigured per-game infrastructure DNS through JSON #19865

Merged
merged 7 commits into from
Jan 13, 2025

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented Jan 11, 2025

This proposes a way to specify per-game DNS resolution through a json file, that we will later make updatable from the PPSSPP website.

Fixes #19848

Don't plan to merge this until I've implemented auto-update and caching of this file, but please feel free to let me know your opinions @anr2me and others :)

The JSON file:
https://github.com/hrydgard/ppsspp/blob/c83636c306f68f8918f1f9db1fecf10e53579083/assets/infra-dns.json

This also removes the ability to specify "secondary DNS".

@hrydgard hrydgard added this to the v1.19.0 milestone Jan 11, 2025
@anr2me
Copy link
Collaborator

anr2me commented Jan 11, 2025

As i remembered there are games that use the Secondary DNS server too, not sure why, may be because my internet have too many lost packet rate back then and the game failed to get a reply from primary server 🤔
I ended setting it to 0.0.0.0 to prevent the game from using it (it used to be 8.8.8.8, which probably a bad idea, since it will resolve to official server)

@a-blondel
Copy link

Maybe you would like to include a DDNS name (when existing) to automatically check IP changes (eg ablondel.ddns.net for MoHH/MoHH2).

The supported game versions are listed here :
https://github.com/a-blondel/mohh-master-server/blob/main/src/main/java/com/ea/utils/GameVersUtils.java (see SLUS_MOHH_PSP_PAL and SLUS_MOHH_PSP_NTSC constants for MoHH)
I may remove the need to check for the game version, this was a prevision in case we split the servers by region for latency issues (as it was back then with official servers).

You'll also find supported versions for MoHH2 (SLUS_MOHH2_PSP_PAL and SLUS_MOHH2_PSP_NTSC) if you want to add it to the list, but for the "comment" on your JSON, only the online menu is accessible yet. The domain entry pspmoh08.ea.com that you added is for MoHH2.

I may not be aware of every versions of the games, I can add any that is missing, as of today no users reported problems. Also note that some versions of the games don't have online features (at least, it was cut from JP and AU regions for MoHH2).

@hrydgard
Copy link
Owner Author

Cool, I'll add entries for MOHH2.

Yeah, I can add a DNS lookup so the json can just contain a domain instead.

@hrydgard hrydgard marked this pull request as ready for review January 13, 2025 00:50
@hrydgard
Copy link
Owner Author

Actually, I think I want to get this in as-is, and on top, add the download + file cache. It works quite well currently, just doesn't auto-update yet.

@hrydgard hrydgard merged commit b5c843f into master Jan 13, 2025
19 checks passed
@hrydgard hrydgard deleted the dns-json branch January 13, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should autoconfigure hosts for Infrastructure
3 participants