Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update draw_text_cocoa.mm #19872

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Update draw_text_cocoa.mm #19872

merged 1 commit into from
Jan 14, 2025

Conversation

MaddTheSane
Copy link
Contributor

Fix memory leak.

@MaddTheSane
Update draw_text_cocoa.mm
f32ed3d 
Fix memory leak.
@anr2me
Copy link
Collaborator

anr2me commented Jan 14, 2025

Btw, does the CTFontRef font = nil; in the TextDrawerFontContext class being used at all? since the CTFontRef font inside the Create method seems to be a local variable.

@MaddTheSane
Copy link
Contributor Author

It does not look like it's being used, no.

@hrydgard
Copy link
Owner

I think I added that when I was trying to get my ttf loaded, but just gave up when it seemed complicated.

@hrydgard hrydgard merged commit 841eb11 into hrydgard:master Jan 14, 2025
19 checks passed
@hrydgard hrydgard added this to the v1.19.0 milestone Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Platform-specific (iOS) Platform-specific (Mac OS X)
Projects
None yet
Milestone
v1.19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@MaddTheSane @anr2me @hrydgard