botonic-react: ReactBot class with typescript #3003
Draft
+215
−208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iru89
force-pushed
the
react-bot-class-with-typescript
branch
from
f905f50 to
a3148c5
Compare
Iru89
force-pushed
the
react-bot-class-with-typescript
branch
from
a3148c5 to
08f2a73
Compare
Iru89
force-pushed
the
react-bot-class-with-typescript
branch
from
6d6cf6e to
5dc3148
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pass ReactBot class to typescript
Add RequestCoreContext type. This is the request that the CoreBot passes to the actions and is used from the RequestContext.
Create requestCoreContext with the values and functions that need RequestContext inside actions
Not only use this requestCoreContext for actions, use it for pre and post functions od the plugins and also in routes