Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agents #462

Closed
wants to merge 13 commits into from
Closed

Agents #462

wants to merge 13 commits into from

Conversation

nsarrazin
Copy link
Collaborator

@nsarrazin nsarrazin commented Sep 25, 2023

Still a WIP

Requires huggingface/huggingface.js#249 as a linked package in local dev mode to work

image

Roadblocks:

  • Need to hook-up agents updates to websearch collapsable modal
  • Need to check the streaming tokens to extract the final answer as it comes. (right now we only parse the JSON when it's done streaming but we would like to stream as it comes in)
  • SDXL pipeline requires base + refiner. We don't currently have an endpoint for the refiner, but it's being worked on internally. base model works fine though.
  • need to check prompts, final answer doesn't reference files for some reason.

@gururise
Copy link
Contributor

gururise commented Sep 25, 2023

WOW! This is amazing. I hope the Agents will be modular/extensible. For example, be able to call replicate SDXL API to use SDXL.
Would love to be able to use Agents with OpenAI or other LLM's (see PR #452)

@nsarrazin
Copy link
Collaborator Author

Tests are failing because we need the new agents release for them to pass.

Road to merging:

  1. Merge Agents in chat ui huggingface.js#249
  2. Do a release on huggingface.js
  3. Add the new release to the deps of chat-ui
  4. Merge this PR
  5. Deploy to prod

Notes:

  • We still don't have a pipeline for SDXL that's base + refiner, or optimized for speed, not sure if we want it before merging
  • We should let the team know before doing comms so we can ensure the sdxl endpoint doesn't die

Let me know what you think @gary149

@nsarrazin nsarrazin marked this pull request as ready for review September 27, 2023 14:17
@nsarrazin nsarrazin marked this pull request as draft October 4, 2023 07:36
@nsarrazin
Copy link
Collaborator Author

Closing this for now, will come back to this later 😁

@nsarrazin nsarrazin closed this Oct 13, 2023
@hungryalgo
Copy link

This is such an amazing and huge feature, when are you @nsarrazin planning to come back to this?
I am guess that you are waiting for the SDXL base + refiner endpoint to be ready?

Will you integrate some of the file drop UI from #442?

@julien-blanchon
Copy link
Contributor

@hungryalgo, I think the dropzone UI was already integrated with #531 and live here https://github.com/huggingface/chat-ui/blob/3cbea3450ddaf06d09a7790c9068bc08340dd425/src/lib/components/chat/FileDropzone.svelte

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants