Skip to content

Record comparision fix #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: edge
Choose a base branch
from
Open

Record comparision fix #303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1d56d1
comparision bugfix
kvechera Mar 14, 2020
9747326
a destroyed record keeps its id and other already loaded attributes
kvechera Mar 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ruby/hyper-model/lib/reactive_record/active_record/instance_methods.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,8 @@ def ==(ar_instance)
return false unless ar_instance.is_a?(ActiveRecord::Base)
return false if ar_instance.new_record?
return false unless self.class.base_class == ar_instance.class.base_class
id == ar_instance.id
return id == ar_instance.id unless id.nil?
attributes == ar_instance.attributes
end

def [](attr)
Expand Down
2 changes: 1 addition & 1 deletion ruby/hyper-model/lib/reactive_record/active_record/reactive_record/getters.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ def non_relationship_getter_common(attr, reload, &block)

def getter_common(attribute, reload)
@virgin = false unless data_loading?
return if @destroyed
return @attributes[attribute] if @destroyed
if @attributes.key? attribute
current_value = @attributes[attribute]
current_value.notify if current_value.is_a? Base::DummyValue
Expand Down