Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement replies #402

Merged
merged 23 commits into from
Dec 3, 2024
Merged

Implement replies #402

merged 23 commits into from
Dec 3, 2024

Conversation

tripledoublev
Copy link
Member

@tripledoublev tripledoublev commented Oct 28, 2024 •
edited
Loading

Working on fediversed replies

@RangerMauve
Copy link
Contributor

Sent a reply to "reader is out post" lets delete all the extra template stuff other than replies for now

@tripledoublev tripledoublev changed the base branch from master to staging November 28, 2024 16:59
@tripledoublev
Copy link
Member Author

Deleted all the extra template stuff in order to focus on replies

@tripledoublev
Copy link
Member Author

image

@tripledoublev tripledoublev marked this pull request as ready for review December 2, 2024 17:35
@tripledoublev tripledoublev mentioned this pull request Dec 2, 2024
Open
4 tasks
@tripledoublev tripledoublev changed the base branch from staging to master December 2, 2024 18:54
@tripledoublev
Copy link
Member Author

Changed the base branch since we do not have moderation enabled on staging.
We could still merge to staging and then to main but we won't be able to confirm replies on staging.
Wondering if the activity pub implementation on staging is still relevant

RangerMauve
RangerMauve requested changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@RangerMauve RangerMauve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind going over the files and removing any that aren't strictly necessary?

_includes/activity_pub/text_modal.html Outdated Show resolved Hide resolved
_includes/activity_pub/login_modal.html Outdated Show resolved Hide resolved
_includes/activity_pub/image_modal.html Outdated Show resolved Hide resolved
@tripledoublev
Copy link
Member Author

Removed all unnecessary modals
ea11f2b

@tripledoublev
Copy link
Member Author

Looks like I removed something I should not have removed. Will look into it after our C-lab call

@tripledoublev tripledoublev merged commit 647016b into master Dec 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RangerMauve RangerMauve Awaiting requested review from RangerMauve

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tripledoublev @RangerMauve @fauno