Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from Value -> fnf/nad error #297

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Move from Value -> fnf/nad error #297

wants to merge 1 commit into from

Conversation

qubixes
Copy link
Collaborator

@qubixes qubixes commented Jan 9, 2025

@maartenschermer Would this be more suitable for you? I haven't looked everywhere to fix all the ValueError that are somewhat non-descriptive. We could also add new exceptions (DataObjectNotFoundError, etc.), but this might be in the end easier for the developer/user in the end?

@maartenschermer
Copy link
Collaborator

I see there's some exceptions in the Python iRODS client that fit the bill (DataObjectDoesNotExist and CollectionDoesNotExist(DoesNotExist), so potentially you could use those, but this PR already works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants