Fix ldflags again

icyflame · Jul 12, 2024 · 6a778d0 · 6a778d0
1 parent 51e49c5
commit 6a778d0
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/.github/workflows/build-binary.yml b/.github/workflows/build-binary.yml
@@ -32,9 +32,11 @@ jobs:
       - name: Build binary for the required OS and architecture
         run: |
           OUTPUT_FILE_NAME="./$(basename ${{ matrix.path-to-build }})-${{ matrix.os-flavor }}-${{ matrix.architecture }}"
-          LDFLAGS='-ldflags="-X \"github.com/icyflame/kindle-my-clippings-parser/internal/env.Version=${{ github.ref }} '"$GITHUB_SHA"'\""'
-          GOOS=${{ matrix.os-flavor }} GOARCH=${{ matrix.architecture }}
+
+          GOOS=${{ matrix.os-flavor }} GOARCH=${{ matrix.architecture }} \
+            -ldflags="-X \"github.com/icyflame/kindle-my-clippings-parser/internal/env.Version=${{ github.ref }} $GITHUB_SHA\"" \
             go build $LDFLAGS -o $OUTPUT_FILE_NAME ${{ matrix.path-to-build }}
+
           sha256sum $OUTPUT_FILE_NAME > $OUTPUT_FILE_NAME.checksum
 
       - name: Print file output of the binary file that was built