Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BREAKING_CHANGE] School config #113

Closed
wants to merge 2 commits into from
Closed

[BREAKING_CHANGE] School config #113

wants to merge 2 commits into from

Conversation

ikhsan3adi
Copy link
Owner

@ikhsan3adi ikhsan3adi commented Jul 21, 2024 •
edited
Loading

  • Add app/Config/School.php
  • Remove app/Config/AbsensiSekolah.php
  • Add new .env variables 
    #--------------------------------------------------------------------
# SCHOOL
#--------------------------------------------------------------------

school.name = 'SMK 1 Indonesia'
school.schoolYear = '2024/2025'

https://codeigniter4.github.io/CodeIgniter4/general/configuration.html

@ikhsan3adi ikhsan3adi added the enhancement New feature or request label Jul 21, 2024
@ikhsan3adi ikhsan3adi self-assigned this Jul 21, 2024
@ikhsan3adi ikhsan3adi added the help wanted Extra attention is needed label Jul 21, 2024
ikhsan3adi
ikhsan3adi commented Jul 21, 2024
View reviewed changes
Copy link
Owner Author

@ikhsan3adi ikhsan3adi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ikhsan3adi ikhsan3adi removed the help wanted Extra attention is needed label Jul 21, 2024
@ikhsan3adi
Copy link
Owner Author

ikhsan3adi commented Jul 21, 2024 •
edited
Loading

Will be merged next week

@ikhsan3adi
Copy link
Owner Author

Conflicted

@ikhsan3adi ikhsan3adi closed this Jul 27, 2024
@ikhsan3adi ikhsan3adi deleted the school-config branch July 27, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ikhsan3adi ikhsan3adi

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ikhsan3adi