Add logo to readme #300
Merged
Add logo to readme #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
We could consider uploading a higher quality logo, but this is not default behaviour in usethis. Probably to keep the page loading time down. |
|
I'm not sure why tests are failing |
peterdesmet
requested changes
Mar 21, 2024
|
@NeleMullens Made a mockup of a version with a red background.
|
|
There was a tiny issue on the right lower corner of the hexagon, where a part of the background was bleeding into the black border. I filled it in with black:
I've also included the sRGB colour profile, and stored it as an interlaced PNG for quicker loading. Not sure that those changes will matter at all because |
|
Love the logo @PietrH, for me this is fine. Feels very Jurassic to me |
Co-Authored-By: Nele Mullens <48283120+nelemullens@users.noreply.github.com>
This was referenced Apr 10, 2024
|
Ready for review, should be able to merge if we agree on the logo. |
peterdesmet
approved these changes
Apr 15, 2024
damianooldoni
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#270 created a logo for the package, this PR adds it to the readme.