Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove predicate functions #321

Merged
merged 20 commits into from
Jul 4, 2024
Merged

Remove predicate functions #321

merged 20 commits into from
Jul 4, 2024

Conversation

PietrH
Copy link
Member

@PietrH PietrH commented Jul 4, 2024

Closes #316

Didn't run unit tests, they are currently broken in the version-1.0 branch

PietrH added 20 commits July 4, 2024 14:27
@PietrH
remove predicate functions, devtools document
037825e
@PietrH
remove predicates vignette
1c6f5ce
@PietrH
remove predicates from get_n_species()
342406f
@PietrH
remove predicates from get_cam_op()
802fa4c
@PietrH
remove predicates from get_custom_effort()
261cd90
@PietrH
remove predicate functions from get_effort()
ab59bc1
@PietrH
fix missing package argument
5a4dd8e
@PietrH
remove filtering from helper get_dep_no_obs()
b6ec9b8
@PietrH
remove filter predicate functions from get_n_individuals()
f7d5be4
@PietrH
remove predicate functions from get_n_obs()
ddd4122
@PietrH
Remove filter predicate functions from get_n_species()
2d9b961
@PietrH
Remove filter predicate functions from get_rai.R
830f957
@PietrH
Remove filter predicate functions from get_record_table()
f4b9bf1
@PietrH
remove filter predicates from map_dep()
b646a05
@PietrH
remove unused triple dots
4178289
@PietrH
remove predicate functions from tests
58ccaf8
@PietrH
remove references to predicate filtering
d938a76
@PietrH
remove unused triple dots argument
41351af
@PietrH
add missing comma
fe64629
@PietrH
devtools::document()
ddbc566
@PietrH PietrH added this to the v1.0 milestone Jul 4, 2024
@PietrH PietrH requested a review from damianooldoni July 4, 2024 13:26
@PietrH PietrH linked an issue Jul 4, 2024 that may be closed by this pull request
Remove predicate functions - use filter_deployments() #316
Closed
6 tasks
damianooldoni
damianooldoni approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@damianooldoni damianooldoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! 🥇 Thanks! Yes, tests will be checked later. Step by step.

@damianooldoni damianooldoni merged commit c8d9062 into version-1.0 Jul 4, 2024
@damianooldoni damianooldoni deleted the remove-pred-functions branch July 4, 2024 13:32
@damianooldoni damianooldoni mentioned this pull request Jul 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damianooldoni damianooldoni damianooldoni approved these changes

Assignees

@damianooldoni damianooldoni

@PietrH PietrH

Labels
None yet
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.

Remove predicate functions - use filter_deployments()
2 participants
@PietrH @damianooldoni