Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter out timelapse #342

Merged
merged 11 commits into from
Oct 30, 2024
Merged

Conversation

damianooldoni
Copy link
Member

@damianooldoni damianooldoni commented Oct 17, 2024

This PR solves #306 by adding an ad-hoc filter function: filter_out_timelapse().

  • Add functionality
  • Add documentation
  • Write unit-tests
  • Update NEWS.md

Reminder: devtools::test() will return a lot of failing tests. That's normal. It's important that devtools::test(filter = "filter_out_timelapse") will run successfully.

@damianooldoni damianooldoni marked this pull request as ready for review October 17, 2024 13:06
@damianooldoni
Copy link
Member Author

Thanks @sannegovaert. I have just noticed you were not among the authors/contributors. Now you are 😄 Affiliations added as in camtrapdp's DESCRIPTION.

@damianooldoni damianooldoni merged commit 7e577e3 into version-1.0 Oct 30, 2024
@damianooldoni damianooldoni deleted the add_filter_out_timelapse branch October 30, 2024 15:31
damianooldoni added a commit that referenced this pull request Oct 30, 2024
Added affiliation in #342 but forgot to compile documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants