Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve login form handling errors #93

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve login form handling errors #93

wants to merge 2 commits into from

Conversation

OmeGak
Copy link
Member

@OmeGak OmeGak commented Oct 10, 2024

The main goals of this PR are:

  • Include information about the user in the InvalidCredentials exception.
  • Allow applications to not reveal if there was NoSuchUser.

OmeGak
OmeGak commented Oct 10, 2024
View reviewed changes
flask_multipass/exceptions.py Outdated Show resolved Hide resolved
@OmeGak OmeGak mentioned this pull request Oct 10, 2024
Draft
1 task
@OmeGak OmeGak changed the title Improve login form handling Improve login form handling errors Oct 10, 2024
@OmeGak OmeGak force-pushed the wip/hide-no-such-user branch from e4f2e21 to 18bc5b4 Compare December 10, 2024 14:45
@OmeGak OmeGak force-pushed the wip/hide-no-such-user branch from 18bc5b4 to f1f6f06 Compare December 10, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThiefMaster ThiefMaster ThiefMaster left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OmeGak @ThiefMaster