Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure IMT classes form correct discriminated union #17

Merged

Conversation

skvelymake
Copy link
Collaborator

@skvelymake skvelymake commented Oct 21, 2024

Overview

Refactor IMT classes to form discriminated unions

Changes

  • Refactor IMTAggregator to use a readonly type property instead of constructor initialization
  • Change IMTHITL from abstract to concrete class and implement a default execute method throwing an error
  • Refactor IMTTransformer to use a discriminated type union property instead of constructor initialization
  • Add a new test file module-type.spec.ts to verify that ModuleType is a correctly discriminated union through instance checks
  • Bump package version from 2.5.0 to 2.5.1

CDM-12098

@skvelymake skvelymake requested a review from a team as a code owner October 21, 2024 20:22
@make-coverage
Copy link

make-coverage bot commented Oct 21, 2024

Unit Test Coverage Report

Metric master ms/correct-discriminated-union-based-on-type-property Status
Statements 85.54% 85.13% 💔
Branches 46.15% 45.35% 💔
Functions 66.07% 64.86% 💔

Copy link

github-actions bot commented Oct 21, 2024

Messages
Your PR title & description are valid

Generated 21. 10. 2024 22:24:08 GMT+2 for 2bd9aad

@skvelymake skvelymake merged commit 8ed9c64 into master Oct 23, 2024
4 of 5 checks passed
@skvelymake skvelymake deleted the ms/correct-discriminated-union-based-on-type-property branch October 23, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants