feat(raf-993): signing of open payments http payload. #3407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for brilliant-pasca-3e80ec canceled.
|
🚀 Performance Test ResultsTest Configuration:
Test Metrics:
📜 Logs |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
test/sign-server/src/app.ts
Outdated
Comment on lines
84
to
116
| app.post('/http-signature-verify', async function handler(ffReq, ffReply) { | ||
| const requestBody = JSON.parse(JSON.stringify(ffReq.body)) | ||
| if (!validateBodyVerifySignature(requestBody as RequestBodySignatureVerify)) { | ||
| return { | ||
| statusCode: '400', | ||
| body: 'Insufficient data in request body' | ||
| } | ||
| } | ||
| const { method, url, headers, body } = requestBody | ||
|
|
||
| if (!headers['signature'] || !headers['signature-input']) { | ||
| return { | ||
| statusCode: '400', | ||
| body: '[signature-input] and/or [signature] headers are missing' | ||
| } | ||
| } | ||
|
|
||
| if (!validateSignatureHeaders({ | ||
| method, | ||
| url, | ||
| headers, | ||
| body | ||
| })) { | ||
| return { | ||
| statusCode: '401', | ||
| body: 'Signature verification failed' | ||
| } | ||
| } | ||
|
|
||
| ffReply.code(200).send({ | ||
| signatureVerified: true | ||
| }) | ||
| }) |
Check failure
Code scanning / CodeQL
Missing rate limiting High test
Copilot Autofix
AI 6 days ago
Copilot could not generate an autofix suggestion
Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Context
Checklist
fixes #numberuser-docslabel (if necessary)