-
Notifications
You must be signed in to change notification settings - Fork 44
[wip]: pr for testing auto deployment to multi env #1723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
aequitas
wants to merge
66
commits into
main
Choose a base branch
from
bikkelhart-redesign-dev3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: new header Created new header: -Responsive -Dark Mode -Language Switch (Not fully tested) -Accessible * feat(frontend/base): add internetnl branding check * fix: header css lint errors and added scroll option when expanded mobile menu doesnt fit vertically * fix: header bug fix mobile menu * fix: header bug fix mobile menu * fix: header bug fix mobile menu * fix: header bug fix * fix: header wijzigingen Wijzigingen: -Betere toegankelijkheid dmv rem waardes en aria attributes -Hover en active states van menu links en logo -Border bottom op header wanneer ie sticky is -transities voor in en uitklappen van subnav/mobile nav -mobile menu gemaakt volgens ontwerp * fix: header bug fix * fix: header color fix * fix: header animatie bug * fix: header variable names, feedback menno * fix: header small fix --------- Co-authored-by: Menno ter Laak <menno@bikkelhart.com>
* feat: new header Created new header: -Responsive -Dark Mode -Language Switch (Not fully tested) -Accessible * fix: button width and close menu with esc * Update global.css * feat: new footer * feat(frontend/base): add internetnl branding check * fix: header css lint errors and added scroll option when expanded mobile menu doesnt fit vertically * fix: header bug fix mobile menu * fix: header bug fix mobile menu * fix: header bug fix mobile menu * fix: header bug fix * fix: header wijzigingen Wijzigingen: -Betere toegankelijkheid dmv rem waardes en aria attributes -Hover en active states van menu links en logo -Border bottom op header wanneer ie sticky is -transities voor in en uitklappen van subnav/mobile nav -mobile menu gemaakt volgens ontwerp * fix: header bug fix * fix: header color fix * fix: header animatie bug * fix: footer changes * fix: header variable names, feedback menno * fix: footer variable changes and hover states * fix: footer padding * Update base.html --------- Signed-off-by: Khdulkadir <144004145+Khdulkadir@users.noreply.github.com> Co-authored-by: Menno ter Laak <menno@bikkelhart.com>
* feat: new header Created new header: -Responsive -Dark Mode -Language Switch (Not fully tested) -Accessible * fix: button width and close menu with esc * Update global.css * feat: new footer * feat: test section homepage * feat: waarom testen sectie * feat: hall of fame sectie * Update base.html * feat: about sectie * fix: about section image links * fix: made hall of fame dynamic * feature: nieuws sectie * fix: hall of fame li height * fix: nieuws sectie fix * feat: faq sectie * feat(frontend/base): add internetnl branding check * fix: header css lint errors and added scroll option when expanded mobile menu doesnt fit vertically * fix: header bug fix mobile menu * fix: header bug fix mobile menu * fix: header bug fix mobile menu * fix: header bug fix * fix: header wijzigingen Wijzigingen: -Betere toegankelijkheid dmv rem waardes en aria attributes -Hover en active states van menu links en logo -Border bottom op header wanneer ie sticky is -transities voor in en uitklappen van subnav/mobile nav -mobile menu gemaakt volgens ontwerp * fix: header bug fix * fix: header color fix * fix: header animatie bug * Create package-lock.json.bak * . * fix: explanation update * . * fix: explanation section add carrousel dots * fix: footer changes * fix: test section changes * fix: hall of fame changes * fix: news section * fix: faq changes * fix: faq changes * fix: faq * fix: header variable names, feedback menno * fix: footer variable changes and hover states * fix: explanation sectie hover en variables * fix: explanation padding * Update base.html * fix: hall of fame variables and lint * fix: about section hover and variables * fix: news section variables and hover * fix: faq variables and transition * feat: test site pagina * fix: test site pagina padding --------- Signed-off-by: Khdulkadir <144004145+Khdulkadir@users.noreply.github.com> Co-authored-by: Menno ter Laak <menno@bikkelhart.com>
* feat: new header Created new header: -Responsive -Dark Mode -Language Switch (Not fully tested) -Accessible * fix: button width and close menu with esc * Update global.css * feat: new footer * feat: test section homepage * feat: waarom testen sectie * feat: hall of fame sectie * Update base.html * feat: about sectie * fix: about section image links * fix: made hall of fame dynamic * feature: nieuws sectie * fix: hall of fame li height * fix: nieuws sectie fix * feat: faq sectie * feat(frontend/base): add internetnl branding check * fix: header css lint errors and added scroll option when expanded mobile menu doesnt fit vertically * fix: header bug fix mobile menu * fix: header bug fix mobile menu * fix: header bug fix mobile menu * fix: header bug fix * fix: header wijzigingen Wijzigingen: -Betere toegankelijkheid dmv rem waardes en aria attributes -Hover en active states van menu links en logo -Border bottom op header wanneer ie sticky is -transities voor in en uitklappen van subnav/mobile nav -mobile menu gemaakt volgens ontwerp * fix: header bug fix * fix: header color fix * fix: header animatie bug * Create package-lock.json.bak * . * fix: explanation update * . * fix: explanation section add carrousel dots * fix: footer changes * fix: test section changes * fix: hall of fame changes * fix: news section * fix: faq changes * fix: faq changes * fix: faq * fix: header variable names, feedback menno * fix: footer variable changes and hover states * fix: explanation sectie hover en variables * fix: explanation padding * Update base.html * fix: hall of fame variables and lint * fix: about section hover and variables * fix: news section variables and hover * fix: faq variables and transition * feat: test site pagina * fix: test site pagina padding * feat: test mail pagina * feat: test connection page * fix: grote refactor om herbruikbaarheid te verbeteren * fix: restructured css * fix: added skip link * fix: commented old code * fix: transition faq item * fix: select element appearance none * fix: updated faq bg --------- Signed-off-by: Khdulkadir <144004145+Khdulkadir@users.noreply.github.com> Co-authored-by: Menno ter Laak <menno@bikkelhart.com>
* feat: new header Created new header: -Responsive -Dark Mode -Language Switch (Not fully tested) -Accessible * fix: button width and close menu with esc * Update global.css * feat: new footer * feat: test section homepage * feat(frontend/base): add internetnl branding check * fix: header css lint errors and added scroll option when expanded mobile menu doesnt fit vertically * fix: header bug fix mobile menu * fix: header bug fix mobile menu * fix: header bug fix mobile menu * fix: header bug fix * fix: header wijzigingen Wijzigingen: -Betere toegankelijkheid dmv rem waardes en aria attributes -Hover en active states van menu links en logo -Border bottom op header wanneer ie sticky is -transities voor in en uitklappen van subnav/mobile nav -mobile menu gemaakt volgens ontwerp * fix: header bug fix * fix: header color fix * fix: header animatie bug * fix: footer changes * fix: test section changes * fix: header variable names, feedback menno * fix: footer variable changes and hover states * fix: test section padding * Update base.html --------- Signed-off-by: Khdulkadir <144004145+Khdulkadir@users.noreply.github.com> Co-authored-by: Menno ter Laak <menno@bikkelhart.com>
- Also fix live-tests
1bf0b2d
to
4762481
Compare
* fix: changed logo inline svg to img * fix: added close mobile nav on escape keypress * fix: added layers.css to fix specificity issues * fix: support for cascade layers geinstalleerd voor postcss * fix: refactoring cards * fix: small fixes * fix: small accessibility fixes * w3c html validator * lighthouse test * screenreader test * Update index.html * fix add node modules to ignore * fix remove cached node modules
* fix: changed logo inline svg to img * fix: added close mobile nav on escape keypress * fix: added layers.css to fix specificity issues * fix: support for cascade layers geinstalleerd voor postcss * fix: refactoring cards * fix: small fixes * fix: small accessibility fixes * w3c html validator * lighthouse test * screenreader test * Update index.html * fix add node modules to ignore * fix remove cached node modules * fix: kennisbank pagina first section * feature: kennisbank pagina --------- Signed-off-by: Khdulkadir <144004145+Khdulkadir@users.noreply.github.com>
* fix: changed logo inline svg to img * fix: added close mobile nav on escape keypress * fix: added layers.css to fix specificity issues * fix: support for cascade layers geinstalleerd voor postcss * fix: refactoring cards * fix: small fixes * fix: small accessibility fixes * w3c html validator * lighthouse test * screenreader test * Update index.html * fix add node modules to ignore * fix remove cached node modules * fix: kennisbank pagina first section * feature: kennisbank pagina * feature nieuws pagina --------- Signed-off-by: Khdulkadir <144004145+Khdulkadir@users.noreply.github.com>
* fix: changed logo inline svg to img * fix: added close mobile nav on escape keypress * fix: added layers.css to fix specificity issues * fix: support for cascade layers geinstalleerd voor postcss * fix: refactoring cards * fix: small fixes * fix: small accessibility fixes * w3c html validator * lighthouse test * screenreader test * Update index.html * fix add node modules to ignore * fix remove cached node modules * fix: kennisbank pagina first section * feature: kennisbank pagina * feature nieuws pagina * feature about pagina
13b7825
to
bf911e7
Compare
bf911e7
to
6a31a73
Compare
d6bc7dc
to
805ef59
Compare
git remote add bikkelhart git@github.com:bikkelhart/internet-nl.git git fetch bikkelhart git checkout --no-overlay bikkelhart/bikkelhart-redesign -- frontend interface/templates interface/static translations git reset HEAD frontend/js/{functions.js,headroom.js} frontend/css/print.css interface/static/question@internet.nl_0x45028563.asc interface/templates/{base-probe,connection}.html git restore frontend/js/{functions.js,headroom.js} frontend/css/print.css interface/static/question@internet.nl_0x45028563.asc interface/templates/{base-probe,connection}.html sed -i "22i\ <script type=\"text/javascript\" src=\"{% static 'js/headroom-min.js' %}\"></script>" interface/templates/base.html sed -i 's@Score laden voor:@{% include "string.html" with name="base_probe_score_loading_newstring" %}@' interface/templates/base-probe.html sed -i "5i\ <script type=\"text/javascript\" src=\"{% static 'js/functions-min.js' %}\"></script>" interface/templates/connection.html git add interface/templates/*.html git rev-parse bikkelhart/bikkelhart-redesign
805ef59
to
f4639a2
Compare
Signed-off-by: Benjamin W. Broersma <bw@broersma.com>
…sing a separate target/image makes config to complicated for the MB's saved.
4360bab
to
760d6b1
Compare
git fetch bikkelhart git fetch internetnl git merge -X theirs internetnl/main git checkout --no-overlay bikkelhart/bikkelhart-redesign -- frontend interface/templates interface/static translations git checkout --no-overlay main -- interface/static/question@internet.nl_0x45028563.asc convert -resize 48x48 interface/static/favicon.{png,ico} git add interface/static/favicon.ico git rm package{,-lock}.json # manual merge of docker/Dockerfile, docker/compose.development.yaml, fix .gitignore, note: changed *.js copy and base template git commit --amend -m "Merge main & update to bikkelhart/internet-nl@$(git rev-parse bikkelhart/bikkelhart-redesign | cut -c1-8)"
760d6b1
to
db3be51
Compare
git fetch bikkelhart git merge -X theirs internetnl/main git checkout --no-overlay bikkelhart/bikkelhart-redesign -- frontend interface/templates interface/static translations git checkout --no-overlay main -- interface/static/question@internet.nl_0x45028563.asc convert -resize 48x48 interface/static/favicon.{png,ico} git add interface/static/favicon.ico git commit --amend -m "Merge main & update to bikkelhart/internet-nl@$(git rev-parse bikkelhart/bikkelhart-redesign | cut -c1-8)"
a59f746
to
4fcee28
Compare
git fetch bikkelhart git merge -X theirs internetnl/main git checkout --no-overlay bikkelhart/bikkelhart-redesign -- frontend interface/templates interface/static translations git checkout --no-overlay main -- interface/static/question@internet.nl_0x45028563.asc convert -resize 48x48 interface/static/favicon.{png,ico} git add interface/static/favicon.ico git commit --amend -m "Merge main & update to bikkelhart/internet-nl@$(git rev-parse bikkelhart/bikkelhart-redesign | cut -c1-8)"
git fetch bikkelhart git merge -X theirs internetnl/main git checkout --no-overlay bikkelhart/bikkelhart-redesign -- frontend interface/templates interface/static translations git checkout --no-overlay main -- interface/static/question@internet.nl_0x45028563.asc interface/templates/statistics.html convert -resize 48x48 interface/static/favicon.{png,ico} git add interface/static/favicon.ico git commit --amend -m "Merge main & update to bikkelhart/internet-nl@$(git rev-parse bikkelhart/bikkelhart-redesign | cut -c1-8)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.