-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added labels to evidences #1771
Conversation
WalkthroughThe changes enhance filtering functionality for evidence records. The Evidence model now extends a filtering mixin and includes a new many-to-many field "filtering_labels" via a migration. The serializer and view have been updated to incorporate this field, allowing evidence to be filtered based on associated labels. On the frontend, an AutocompleteSelect component is integrated into the EvidenceForm, and the CRUD mappings, schema definitions, and table view configurations are adjusted to support filtering_labels. These modifications synchronize filtering labels support across both backend and frontend. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant UI
participant Frontend
participant Backend
participant Serializer
participant Model
User->>UI: Select filtering labels via Autocomplete
UI->>Frontend: Submit evidence form data
Frontend->>Backend: Request evidence data with filtering_labels
Backend->>Serializer: Serialize Evidence (including filtering_labels)
Serializer->>Model: Retrieve filtering_labels associations
Model-->>Serializer: Return filtering labels data
Serializer-->>Backend: Deliver serialized data
Backend-->>Frontend: Respond with enriched evidence details
Frontend-->>UI: Display evidence with filtering labels
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (9)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Update 0066_evidence_filtering_labels.py ruff
9e549ed
to
ad314e5
Compare
added labels to evidences with a filter on labels and auto creation in the form.
Summary by CodeRabbit