Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-vite): add missing peer dependencies #1819

Merged
merged 4 commits into from
Nov 14, 2023
Merged

Conversation

sean-perkins
Copy link
Contributor

@sean-perkins sean-perkins commented Nov 10, 2023

Resolves #1816

The react vite base project has missing peer dependencies that will fail when building with a package manager like yarn or pnpm.

@sean-perkins sean-perkins marked this pull request as ready for review November 10, 2023 20:34
@sean-perkins sean-perkins requested a review from a team as a code owner November 10, 2023 20:34
@sean-perkins sean-perkins requested review from thetaPC and removed request for a team November 10, 2023 20:34
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with minor suggestion

react-vite/base/package.json Outdated Show resolved Hide resolved
sean-perkins and others added 2 commits November 13, 2023 19:28
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
@sean-perkins sean-perkins enabled auto-merge (squash) November 14, 2023 00:28
@sean-perkins sean-perkins merged commit 93bed6d into main Nov 14, 2023
30 checks passed
@sean-perkins sean-perkins deleted the sp/react-vite branch November 14, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants