-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing small bugs and improving output #19
Conversation
rabrie
commented
Dec 16, 2024
•
edited
Loading
edited
- Fixed GHZ plot showing wrong qubit counts
- Add GST config variable to pass to run_MGST(..., testing=) for plots
- In mgst.algorithm at line 721 add success=1 so that correct message is printed if the threshold was not reached but the alg. converged (with model mismatch etc.)
- Add note about the GST optional dependency in the installation guide somewhat prominently and also in the GST example notebooks.
- mGST docstrings in low_level_jit are wrong: "derivative by dK" instead of "derivative of dK" and so on
- Add gate labels qubit indices to GST gate labels in the compressive_gst.py
- GST saves an empty "y" in init
- Transpiled and untranspiled circuits were swapped in circuit class change for GST
- GHZ Fidelity plot: Adding grid, better x-labels, backend and timestamp in title, consistent coloring
- Added remaining GST print statements to log
…erator code in GST
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only noticed little issues in docstrings for the GST files (some parameters missing, for example), but this doesn't have to be resolved in this PR. I'll continue reviewing the checklist points.
Co-authored-by: Rakhim Davletkaliyev <rakhim.davletkaliyev@meetiqm.com>
Co-authored-by: Rakhim Davletkaliyev <rakhim.davletkaliyev@meetiqm.com>
Co-authored-by: Rakhim Davletkaliyev <rakhim.davletkaliyev@meetiqm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving now, given that the issues with the new circuit container are critical; can address the smaller comments in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
neat! I've seen the prints changed to loggings now too, things look good from my side