Add all example notebooks to docs #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbrazinskas
reviewed
Jan 14, 2025
src/iqm/benchmarks/__init__.py
Outdated
| @@ -26,7 +26,6 @@ | |||
| BenchmarkRunResult, | |||
| ) | |||
| from .circuit_containers import BenchmarkCircuit, CircuitGroup, Circuits | |||
| from .compressive_gst.compressive_gst import CompressiveGST, GSTConfiguration | |||
There was a problem hiding this comment.
Could you pull the latest changes from main into your branch?
There was a PR a few days ago handling the import issue.
There was a problem hiding this comment.
Done. (Also updated changelog.)
manzanillo
reviewed
Jan 14, 2025
| @@ -0,0 +1,8 @@ | |||
| Development | |||
There was a problem hiding this comment.
Maybe "Development" is a little ambigous.
How about "Custom Benchmarks"?
There was a problem hiding this comment.
@rabrie what's your opinion?
There was a problem hiding this comment.
Custom benchmarks would fit too, but I'm worried that a user could think this means adapting the settings of an existing benchmark, rather than creating one from scratch.
There was a problem hiding this comment.
I'll leave it for now.
Co-authored-by: Stefan Seegerer <stefan.seegerer@meetiqm.com>
Co-authored-by: Stefan Seegerer <stefan.seegerer@meetiqm.com>
manzanillo
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding all (remaining) example notebooks to docs:
Added new "Development" section
Adapted
.gitignore.