Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#111] OIDC setup docs #112

Merged
merged 1 commit into from
Oct 26, 2023
Merged

[#111] OIDC setup docs #112

merged 1 commit into from
Oct 26, 2023

Conversation

MartinFlores751
Copy link
Contributor

No description provided.

trel
trel reviewed Oct 6, 2023
View reviewed changes
Copy link
Member

@trel trel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good start. is this comprehensive? point to the example config which has the things mentioned... ?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@trel
Copy link
Member

trel commented Oct 25, 2023

looking very good. i'm happy with these words.

alanking
alanking reviewed Oct 25, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@MartinFlores751 MartinFlores751 marked this pull request as ready for review October 25, 2023 18:24
alanking
alanking reviewed Oct 25, 2023
View reviewed changes
Copy link

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Definitely deferring to others on this one :)

korydraughn
korydraughn reviewed Oct 25, 2023
View reviewed changes
Copy link
Contributor

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.

Once the comment is resolved, squash without the pounds.

README.md Outdated Show resolved Hide resolved
korydraughn
korydraughn approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pound when ready.

@MartinFlores751
Copy link
Contributor Author

Pounded!

@alanking alanking merged commit b8e7cc6 into irods:main Oct 26, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanking alanking alanking left review comments

@trel trel trel left review comments

@korydraughn korydraughn korydraughn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MartinFlores751 @trel @korydraughn @alanking