Add progress bar update capability to data transfers in iRODS #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanking
reviewed
Jul 3, 2024
alanking
reviewed
Jul 12, 2024
|
@d-w-moore - Anything left to do here? |
I think not. I'll look it over once more to be sure, and post another comment when that "internal review" is complete. |
|
Rebased to upstream main. |
|
One test was broken for the progressbar2 library... which i believe is the more current version of progressbar. So that's fixed now. |
alanking
reviewed
Jul 30, 2024
There was a problem hiding this comment.
Looks like there are a couple Codacy things that may be worth addressing. Other than my one comment, things seem fine.
Please consider the plan for those first two commits (squashing, removal with co-author credit on the new commit(s), adding issue numbers, etc.).
d-w-moore
force-pushed
the
add-tqdm-pbar
branch
from
0f5aff0 to
4afb6bd
Compare
Works for both parallel as well as single threaded gets and puts.
updatable objects are either bound update functions taking a number of bytes in a transfer, or progress-bar objects. If the latter, the object's type must already be registered. (See tests: Use of the progressbar and tqdm modules is demonstrated.)
d-w-moore
force-pushed
the
add-tqdm-pbar
branch
from
4afb6bd to
39d2ecc
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Designed in such as way as to be foreseeably generic and /or adaptable to multiple progress bar libraries.
progressbarandtqdmare demonstrated as compatible.This PR may end up supplanting #575