Skip to content

Ada iconography consistency #1408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: redesign-2024
Choose a base branch
from
Open

Conversation

jacbn
Copy link
Contributor

@jacbn jacbn commented Apr 28, 2025

Adds the basis for icons on Ada to work in the same way as they do on the Physics redesign.
Also adjusts the ascent-override property of Ada fonts to correctly vertically align the font, which has been ~2px too high since the site's inception, to make sure text-aligned elements (like icons) actually look aligned.

Copy link

codecov bot commented Apr 28, 2025

Codecov Report

Attention: Patch coverage is 54.38596% with 26 lines in your changes missing coverage. Please review.

Project coverage is 40.92%. Comparing base (71878d0) to head (55cd478).
Report is 2 commits behind head on redesign-2024.

Files with missing lines Patch % Lines
src/app/services/search.ts 26.92% 19 Missing ⚠️
src/app/components/elements/SearchInputs.tsx 73.07% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           redesign-2024    #1408      +/-   ##
=================================================
+ Coverage          40.90%   40.92%   +0.01%     
=================================================
  Files                493      493              
  Lines              21870    21874       +4     
  Branches            7195     7237      +42     
=================================================
+ Hits                8946     8951       +5     
+ Misses             12305    12304       -1     
  Partials             619      619              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant