KHR pbr neutral tonemap #2547
Open
KHR pbr neutral tonemap #2547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riccardobl
commented
Aug 10, 2025
| private static final float DEFAULT_GAMMA = 1.0f; | ||
|
|
||
| private final Vector3f exposure = new Vector3f(DEFAULT_EXPOSURE, DEFAULT_EXPOSURE, DEFAULT_EXPOSURE); | ||
| private final Vector3f gamma = new Vector3f(DEFAULT_GAMMA, DEFAULT_GAMMA, DEFAULT_GAMMA); |
There was a problem hiding this comment.
i've used vectors here so it gives more artistic control, kinda doubling as color correction
riccardobl
commented
Aug 10, 2025
|
|
||
| float g = 1. - 1. / (desaturation * (peak - newPeak) + 1.); | ||
| color = mix(color, newPeak * vec3(1, 1, 1), g); | ||
| color = pow(color, gamma); |
There was a problem hiding this comment.
afaik this is the order used in blender to apply gamma and exposure, but i am not 100% sure on this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Khronos PBR Neutral Tone Map for jme. It is basically just this shader put in a filter with some adaptations.
It is a another standard algorithm for tone mapping, that is available also in blender, making it a better choice to have renders that are consistent with what you see in blender.