New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyproject.toml: Allow maturin >= 1.8.0 to fill the version #226

Merged

jamesturk merged 1 commit into jamesturk:main from heirecka:allow-maturin-1-8-0-fill-the-version

Dec 31, 2024

Contributor

heirecka commented Dec 28, 2024

maturin >= 1.8.0 stopped filling the version from Cargo.toml, because the spec only allows this, when the metadata key is listed in dynamic [1][2].

Fixes #224.

[1] https://packaging.python.org/en/latest/specifications/pyproject-toml/#dynamic
[2] PyO3/maturin#2390


          pyproject.toml: Allow maturin >= 1.8.0 to fill the version

e4936cc

maturin >= 1.8.0 stopped filling the version from Cargo.toml, because
the spec only allows this, when the metadata key is listed in
`dynamic` [1][2].

Fixes jamesturk#224.

[1] https://packaging.python.org/en/latest/specifications/pyproject-toml/#dynamic
[2] PyO3/maturin#2390

wu7zh mentioned this pull request

Update pyproject.toml #225

Closed

jamesturk merged commit dce22ae into jamesturk:main

25 checks passed

Owner

jamesturk commented Dec 31, 2024

thank you!

heirecka deleted the allow-maturin-1-8-0-fill-the-version branch

January 2, 2025 10:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet