싸인 재활용하는 옵션 추가 #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
모종의 이유로 기대와 다른 pdf 가 생성될 경우 다시 돌려야하는데 그때마다 서명을 하는게 번거로워 구현
jen6
requested changes
Jan 11, 2021
| async function getSignature() { | ||
| function getSignatureFilePath() { | ||
| const tmpDir = os.tmpdir(); | ||
| filePath = path.join(tmpDir, "workDiary-signature.png"); |
There was a problem hiding this comment.
최근 제가 사용하는 cli 툴들은 대부분 ~/.config/application-name 이런식으로 생성해서 사용하는것 같습니다.
tmp 폴더도 상관없긴하지만 이왕이면 폴더를 생성하거나 하면 좋을듯 합니다
|
|
||
| async function getSignature(isReuseSign) { | ||
| var data = ""; | ||
| if (isReuseSign === true) { |
There was a problem hiding this comment.
early return 으로 해주시면 가독성이 좀 올라갈것 같습니다
if (isReuseSign === false) {
return
}
~~| @@ -285,6 +310,9 @@ async function main(){ | |||
| if (typeof year === "undefined") { | |||
| year = new Date().getFullYear().toString(); | |||
| } | |||
| const reuseSign = myArgs.filter((arg) => arg === "--reuse-sign"); | |||
There was a problem hiding this comment.
이거 위에 example이랑 Usage 에도 추가해주실 수 있을까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
csv.csv 2021 --reuse-sign위처럼 --reuse-sign 옵션으로 싸인 그리는 과정을 스킵합니다.
tmp folder에 만들었던 싸인을 저장하는 방식이고 아무 옵션도 주지 않으면 기존처럼 매번 웹 브라우저를 띄워줍니다.
생성된 pdf 가 기대와 다를 때 싸인은 또 매번 해줘야 하는게 번거로워 구현했습니다.