Minor improvements to JGitLightweightTagTest #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepare for JGit 7.2.0 where the `packRefs()` method will be publicly available instead of requiring a JGit internal API. Document that the packRefs() call is required in order to confirm that the previous bug in JGitAPIImpl is still fixed. I reverted the fix and confirmed that without the call to `packRefs()` the bug is not shown by the test. Assert that the set of tags has the correct size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor improvements to JGitLightweightTagTest
Prepare for JGit 7.2.0 where the
packRefs()method will be publicly available instead of requiring a JGit internal API.Document that the
packRefs()call is required in order to confirm that the previous bug in JGitAPIImpl is still fixed. I reverted the fix and confirmed that without the call topackRefs()the bug is not shown by the test.Assert that the set of tags has the correct size.
Testing done
Automated tests pass and the set of diffs that will be needed for JGit 7.2.0 are reduced a little bit.
Submitter checklist