Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-lockWorkDir #793

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

-lockWorkDir #793

wants to merge 5 commits into from

Conversation

jglick
Copy link
Member

@jglick jglick commented Mar 24, 2025 •
edited
Loading

(CloudBees-internal issue)

Tested on both Linux and Windows 10.

@jglick jglick requested a review from Vlatombe March 25, 2025 17:41
@jglick jglick changed the title Agent lock file -lockWorkDir Mar 25, 2025
@jglick jglick added the enhancement For changelog: An enhancement providing new capability. label Mar 25, 2025
jglick
jglick commented Mar 25, 2025
View reviewed changes
src/main/java/hudson/remoting/Engine.java

public Engine(EngineListener listener, List<URL> hudsonUrls, String secretKey, String agentName) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither overload was used externally so far as I can tell.

Vlatombe
Vlatombe approved these changes Mar 26, 2025
View reviewed changes
Copy link
Member

@Vlatombe Vlatombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be worth adding a high level description for the changelog?

@jglick
Copy link
Member Author

jglick commented Mar 26, 2025

Probably so, and I think -lockWorkDir ought to be included in https://github.com/jenkinsci/jenkins/blob/dddb4598df25527220a1e0f46d1a0d25217dd4c8/core/src/main/java/jenkins/slaves/RemotingWorkDirSettings.java#L133 for the suggest command line for a permanent agent. (If you are seeing that page, it is presumably not a cloud agent.) And included in some integration tests in core using a forked java -jar agent.jar.

Keeping in draft for now pending feedback from a CloudBees CI customer who reported observing multiple processes for a given agent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vlatombe Vlatombe Vlatombe approved these changes

Assignees
No one assigned
Labels
enhancement For changelog: An enhancement providing new capability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jglick @Vlatombe