Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

also use the super class method to get standard manager features #246

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

also use the super class method to get standard manager features #246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/main/java/hudson/scm/SVNAuthenticationManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,10 @@ public SVNAuthenticationManager(File configDir, String userName, String password
@CheckForNull
public SVNAuthentication getFirstAuthentication(String kind, String realm, SVNURL url) throws SVNException {
// SVNKIT DefaultAuthenticationManager ignores any credentials that are added to the manager.
return super.getAuthenticationProvider().requestClientAuthentication(kind, url, realm, null, null, false);
SVNAuthentication authentication = super.getAuthenticationProvider().requestClientAuthentication(kind, url, realm, null, null, false);
if (authentication == null) {
authentication = super.getFirstAuthentication(kind, realm, url);
}
return authentication;
}
}