Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the value of agent_name for AWS runner registration #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jamielennox
Copy link

When using AWS agents we don't have a single agent name, and the
provided example agent_name of "{{build_name}}-{{user build_number}}"
doesn't really explain what this value should be.

This was confusing for me when going through the README and trying to
set this up so I assume it will be for others as well.

When using AWS agents we don't have a single agent name, and the
provided example agent_name of "{{build_name}}-{{user `build_number`}}"
doesn't really explain what this value should be.

This was confusing for me when going through the README and trying to
set this up so I assume it will be for others as well.
@mkuzmin
Copy link
Contributor

mkuzmin commented Oct 26, 2018

Hi Jamie!

Originally this plugin was developed for VMware vSphere, and even within JetBrains we don't use it with AWS yet.
TeamCity EC2 plugin has several issues listed in TW-55902 which don't allow to automate this agent update process reliably.
On the Packer side it also required a couple of breaking changes, look at latest commits.

Now we are waiting till these TeamCity issues are fixed, and 2018.2 is released. Then I'll publish the new version of the plugin.

@matt-richardson
Copy link

👋 It appears that that issue got merged. Looks like this can get released?

Only thing is, it looks like it will still run into the "old instances are not terminated" issue still. Any knews on whether that's been fixed? I might have still have to stick with my current post-build script solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants