Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement CI pipeline status reporting when evaluating MR #17

Merged
merged 10 commits into from
May 11, 2024

Conversation

jippi
Copy link
Owner

@jippi jippi commented May 11, 2024

Breaking change:

--commit / $CI_COMMIT_SHA variable

scm-engine evaluate now requires --commit (or env CI_COMMIT_SHA) to work.

The CI_COMMIT_SHA variable is provided in GitLab CI pipelines automatically; so hopefully shouldn't break anything.

--update-pipeline / $SCM_ENGINE_UPDATE_PIPELINE (default: true)

Projects without CI pipelines might fail due to lack of CI pipeline API; other projects should now see an external CI pipeline status from scm-engine showing success/failure + relevant error message when scm-engine is processing an MR

@jippi jippi self-assigned this May 11, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 77 lines in your changes are missing coverage. Please review.

Project coverage is 0.00%. Comparing base (c35eee6) to head (97eb963).

Files Patch % Lines
pkg/scm/gitlab/client.go 0.00% 23 Missing ⚠️
pkg/state/context.go 0.00% 16 Missing ⚠️
cmd/cmd_server.go 0.00% 12 Missing ⚠️
cmd/cmd_evaluate.go 0.00% 11 Missing ⚠️
pkg/scm/gitlab/client_merge_request.go 0.00% 9 Missing ⚠️
cmd/shared.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main     #17   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         30      30           
  Lines       1271    1319   +48     
=====================================
- Misses      1271    1319   +48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jippi jippi merged commit 6ea0353 into main May 11, 2024
8 checks passed
@jippi jippi deleted the add-pipeline-update branch May 11, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants