Update cloudbridge-mattermost.php #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This property on this class was being used but never declared.
|
I am running php 8.3 and this missing property make php scream at me :) (it also shows as an error on php 8.2) |
The call back url is not documented anywhere. I talked to a coworker doing wp themes and said they dropped this plugin because they couldn't figure out where they supposed to use as the callback. I went on searching for it and after a few tries I got the right url. It doesn't hurt to put it out there to make it easier for anyone struggling with the same.
line 218 I commented out because $e is not available at this point in the application. To use it should be set or have a try catch but this elseif isn't included in one. line 221, I replaced the filter as in php 8.3 that filter doesn't exists anymore. In its place I put FILTER_SANITIZE_FULL_SPECIAL_CHARS. Although I didn't code this plugin, I imagine the behavior is similar to what the programmer who coded this lines wanted to have. Sanitization.
joho1968
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This property on this class was being used but never declared.
Thanks!