Skip to content
This repository was archived by the owner on Jan 9, 2021. It is now read-only.

Fix broken references #88

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jugglinmike
Copy link

Revision 36 of the ES6 spec (the latest at the time of this writing) includes three references that are not recognized by this script. For example:

screenshot from 2015-03-24 12 52 17

I'm not sure if you prefer built changes to be included in pull requests (this might be worth noting in a CONTRIBUTING.md file), so I'm playing it safe an omitting them from this patch. I'm happy to include them, though--just let me know. For now, I'll paste a word diff here:

$ git diff --word-diff
diff --git a/es6-draft.html b/es6-draft.html
index e65b20e..17473d6 100644
--- a/es6-draft.html
+++ b/es6-draft.html
@@ -32626,13 +32626,14 @@
  <p>Unless otherwise specified, the <code>name</code> property of a built-in Function object, if it exists,  has the attributes
  {&nbsp;[[Writable]]: <b>false</b>, [[Enumerable]]: <b>false</b>, [[Configurable]]: <b>true</b> }.</p>

  <p>Every other data property described in clauses 18 through 26 and in Annex [-{ REF _Ref406169814 \n \h }B.2-]{+<a+}
{+  href="#sec-additional-built-in-properties">B.2</a>+} has the attributes { [[Writable]]: <b>true</b>, [[Enumerable]]: <b>false</b>,
  [[Configurable]]: <b>true</b> } unless otherwise specified.</p>

  <p>Every accessor property described in clauses 18 through 26 and in Annex [-{ REF _Ref406169814 \n \h }B.2-]{+<a href="#sec-additional-built-in-properties">B.2</a>+}
  has the attributes {[[Enumerable]]: <b>false</b>, [[Configurable]]: <b>true</b> } unless otherwise specified. If only a get
  accessor function is described, the set accessor function is the default value, <b>undefined</b>. If only a set accessor is
  described the get accessor is the default value, <b>undefined</b>.</p>
</section>

<section id="sec-global-object">
@@ -45312,8 +45313,8 @@

          <p>If <var>comparefn</var> is not <b>undefined</b> and is not a consistent comparison function for the elements of this
          array (see below), the sort order is implementation-defined. The sort order is also implementation-defined if
          <var>comparefn</var> is <b>undefined</b> and <a href="#sec-sortcompare">SortCompare</a> [-({ REF _Ref393437395 \n \h-]
[-          }22.1.3.24.1)-]{+(<a+}
{+          href="#sec-sortcompare">22.1.3.24.1</a>)+} does not act as a consistent comparison function.</p>

          <p>Let <var>proto</var> be <var>obj</var>.[[GetPrototypeOf]](). If <var>proto</var> is not <b>null</b> and there exists
          an integer <var>j</var> such that all of the conditions below are satisfied then the sort order is

This entry no longer exists, so its presence causes the conversion
script to fail.
Some references are encoded with an escaped newline pattern in the
source text. Update the transformation script to recognize these
references as valid.
@claudepache
Copy link

The issue is still present in the final spec hosted at http://www.ecma-international.org/ecma-262/6.0/ : There are five occurrences of/\{ REF _Ref\d+ (\\[rnh*] |MERGEFORMAT )+\}/. (In all of them, the \h sequence occurs.)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants