bug: fix anchor hover color/behavior in dark mode #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for hugo-congo ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR fixes an issue with anchor hover links in dark mode.
in light mode, hovering your cursor next to an h2/h3/etc header triggers an anchor to appear in an accent color (based on your chosen color scheme). if you move your cursor away, the anchor fades quickly.
currently, in dark mode, hovering your cursor next to the same h2/h3/etc header triggers an anchor to appear, but with a notable lack of color and odd "flashing" behavior:
this fix changes the relevant dark mode CSS class from
--color-neutral-700to--color-primary-700. after implementing this change, anchor links in dark mode now appear in an appropriate accent color and with a smooth, non-flashing hover transition:(light mode is unaffected by this change.)