Skip to content

Update Logo to X in README for Consistency #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

adityajha2005
Copy link

What kind of change does this PR introduce?

Enhancement : Updated logo of Twitter to X because of the rebranding

Issue Number:

Screenshots/videos:

Before :
image

After :
image

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

@DhairyaMajmudar
Copy link
Member

@adityajha2005 Thanks for PR but as its seen the new logo of X won't look good when user is using GitHub in dark mode. Can you find a solution for this ?

@DhairyaMajmudar DhairyaMajmudar self-requested a review March 10, 2025 06:27
@adityajha2005
Copy link
Author

@adityajha2005 Thanks for PR but as its seen the new logo of X won't look good when user is using GitHub in dark mode. Can you find a solution for this ?

@DhairyaMajmudar Alternatively, I can use an image with an opaque background like this
image

@DhairyaMajmudar
Copy link
Member

Awsm! Go with this

@adityajha2005
Copy link
Author

mb, i'll just open another pr once it's done @DhairyaMajmudar

@DhairyaMajmudar
Copy link
Member

mb, i'll just open another pr once it's done @DhairyaMajmudar

Update in this PR only

@adityajha2005
Copy link
Author

Update in this PR only

GitHub README doesn’t support dynamic theme switching, so the X logo may not be visible properly in dark mode. To fix this, we’ll need an SVG with an opaque background. Let me know what you think!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Enhancement: Update Twitter Logo to X in README for Consistency
2 participants