Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .vscode directory to .gitignore #3

Closed
wants to merge 2 commits into from

Conversation

julbean
Copy link
Owner

@julbean julbean commented Feb 26, 2024

No description provided.

@julbean
Copy link
Owner Author

julbean commented Feb 26, 2024

@linuxdaemon
PR to remove a file specific to an environment (VS Code config) from repo

@linuxdaemon
Copy link
Contributor

This was explicitly added as settings for this project as we need to disable whitespace trim for anyone using vscode, otherwise it will wipe out the indentation on blank lines

@julbean
Copy link
Owner Author

julbean commented Feb 27, 2024

I understand you having the folder/config on your system, since you're using VS Code, but that seems like exactly the kind of thing .gitignore is for. I don't think it's worth bloating the repo with config files for every editor that deletes blank line whitespace by default just so potential future contributors might save a minute if they happen to use that editor

@julbean
Copy link
Owner Author

julbean commented Feb 27, 2024

I found a poll that says a substantial portion of Python devs use VS Code nowadays, so I actually think keeping it might be reasonable after all:
https://lp.jetbrains.com/python-developers-survey-2022/#DevelopmentTools
Did you say PyCharm also deletes blank line whitespace? Could be worth adding a config for that one as well, given it has similar market share to VS Code (~30%).

@julbean julbean closed this Feb 27, 2024
@linuxdaemon
Copy link
Contributor

Pycharm does yep, I can open the repo in my copy and see what the setting is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants