Deal with panic, improve alloc in color_cycle, swap 3D rectpack for packr2 using Skyline #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isinyaaa
commented
Mar 18, 2025
| @@ -86,54 +91,41 @@ impl StatefulWidgets { | |||
| // } | |||
|
|
|||
| pub fn selected_category_widget(&self, keymap_context: &KeyMapContext) -> &ShortcutsWidget { | |||
| let idx = keymap_context.category_idx().expect("no category selected"); | |||
| let idx = keymap_context.category_idx().unwrap_or(0); //.expect("no category selected"); | |||
There was a problem hiding this comment.
Instead of this, maybe you just don't want to have an option for the current_category field, and keep the last selection after (DeselectCategory)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, cool project, just spent some time studying your implementation, here are some minor enhancements.
I'll leave another comment inline that I can also fix if you want.
Ah, another thing: in main you are unwrapping an error an that's what makes panics behave badly (terminal state is not reset), so you might also want to collect the error before resetting ratatui.